[LTP] [PATCH v2 1/5] tst_mallinfo.c: Add a common print helper for mallinfo

Petr Vorel
2021-02-05T11:21:27Z

Hi Xu, Li,

> > > --- /dev/null
> > > +++ b/include/tst_mallinfo.h

> > > Do we really need to export this function into the LTP library?
> > > (I assumed no other tests will using this lib function anymore)
> > Maybe we can add tst_print_mallinfo2 in the future and mallinfo2() case
> > can use this header.

> Or put it into the tst_memutils.h, I guess this header file is a
> general-purpose for providing kinds of memory helpers.

Either ways are ok for me. tst_memutils.h is a bit cleaner approach,
but given the fact that not many tests will use it having it in
into testcases/kernel/syscalls/mallinfo/ and source it with relative path in
mallopt01.c is also ok for me.

Kind regards,
Petr

> > > So I prefer to create a common header file as:
> > > ../syscalls/mallinfo/mallinfo_common.h,
> > > and just use it locally.

> > > If you're hoping mallopt01.c also benefits from it, only need to
> > > build something like mallinfo_commo.o via Makefile and include
> > > it in mallopt01.c by "../mallinfo/mallinfo_common.h".
> > Just want to avoid random makefile. I am not sure which way is better.
> > Let's listen advise from other maintainers.

> Sure, my pleasure to hear more voice~