[LTP] [PATCH v2 1/5] tst_mallinfo.c: Add a common print helper for mallinfo

Yang Xu
2021-02-05T07:44:45Z

Hi Li
> Hi Xu,
>
> Thanks for your work.
>
> --- /dev/null
> +++ b/include/tst_mallinfo.h
>
>
> Do we really need to export this function into the LTP library?
> (I assumed no other tests will using this lib function anymore)
Maybe we can add tst_print_mallinfo2 in the future and mallinfo2() case
can use this header.

>
> So I prefer to create a common header file as:
> ../syscalls/mallinfo/mallinfo_common.h,
> and just use it locally.
>
> If you're hoping mallopt01.c also benefits from it, only need to
> build something like mallinfo_commo.o via Makefile and include
> it in mallopt01.c by "../mallinfo/mallinfo_common.h".
Just want to avoid random makefile. I am not sure which way is better.
Let's listen advise from other maintainers.
>
> --
> Regards,
> Li Wang