From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fanotify13.c/setxattr01.c: Remove requirement of needs_tmpdir
Date: Mon, 1 Mar 2021 09:48:51 +0800 [thread overview]
Message-ID: <603C4803.5090909@cn.fujitsu.com> (raw)
In-Reply-To: <20210227033230.175881-1-zhaogongyi@huawei.com>
Hi gongyi
> The testcases aim to run on all_filesystems, so we need remove the
> requirement of needs_tmpdir.
>
This commit message is confusing. See commit dae8427740f(" Remove
duplicated ".needs_tmpdir=1" when using equivalent flags").
The needs_tmpdir flag is not needed to be set when use these flags:
'.all_filesystems', '.format_device', '.mntpoint', '.mount_device'
'.needs_checkpoints', '.needs_device', '.resource_file'.
These flags imply creating temporary directory.
Does have other case still have this duplicated flag?
> Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> ---
> testcases/kernel/syscalls/fanotify/fanotify13.c | 1 -
> testcases/kernel/syscalls/setxattr/setxattr01.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify13.c b/testcases/kernel/syscalls/fanotify/fanotify13.c
> index 6d812cdd1..1fb12ae68 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify13.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify13.c
> @@ -289,7 +289,6 @@ static struct tst_test test = {
> .setup = do_setup,
> .cleanup = do_cleanup,
> .needs_root = 1,
> - .needs_tmpdir = 1,
> .mount_device = 1,
> .mntpoint = MOUNT_PATH,
> .all_filesystems = 1,
> diff --git a/testcases/kernel/syscalls/setxattr/setxattr01.c b/testcases/kernel/syscalls/setxattr/setxattr01.c
> index 8b84dfe0d..8cd2821d0 100644
> --- a/testcases/kernel/syscalls/setxattr/setxattr01.c
> +++ b/testcases/kernel/syscalls/setxattr/setxattr01.c
> @@ -210,7 +210,6 @@ static struct tst_test test = {
> .mntpoint = MNTPOINT,
> .mount_device = 1,
> .all_filesystems = 1,
> - .needs_tmpdir = 1,
> .needs_root = 1,
> };
>
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2021-03-01 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 3:32 [LTP] [PATCH] fanotify13.c/setxattr01.c: Remove requirement of needs_tmpdir Zhao Gongyi
2021-03-01 1:48 ` Yang Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-01 2:30 zhaogongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603C4803.5090909@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox