public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: yangx.jy@fujitsu.com <yangx.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] min_kver: Add kernel version requestions
Date: Tue, 30 Mar 2021 08:05:39 +0000	[thread overview]
Message-ID: <6062DBD2.30501@fujitsu.com> (raw)
In-Reply-To: <20210330074437.3208-1-zhaogongyi@huawei.com>

Hi Zhongyi,

Do you get any issue here?

It is unncessary to add version check because LTP has check the support 
of  preadv2/pwritev2:
1) Call preadv2/pwritev2 directly if glibc provides it.
2) Call syscall(__NR_preadv2/__NR_pwritev2) if glibc doesn't provides 
preadv2/pwritev.
3) Report TCONF if kernel doesn't support __NR_preadv2/__NR_pwritev2.

Please reference "include/lapi/preadv2.h"

Best Regards,
Xiao Yang
On 2021/3/30 15:44, Zhao Gongyi wrote:
> We need add kernel version requestions sinc preadv2() and pwritev2()
> first appeared in Linux 4.6.
>
> For those:
> 	testcases/kernel/syscalls/preadv2/preadv201.c
> 	testcases/kernel/syscalls/pwritev2/pwritev201.c
>
> Signed-off-by: Zhao Gongyi<zhaogongyi@huawei.com>
> ---
>   testcases/kernel/syscalls/preadv2/preadv201.c   | 1 +
>   testcases/kernel/syscalls/pwritev2/pwritev201.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/preadv2/preadv201.c b/testcases/kernel/syscalls/preadv2/preadv201.c
> index 91e2b9889..e8220f94c 100644
> --- a/testcases/kernel/syscalls/preadv2/preadv201.c
> +++ b/testcases/kernel/syscalls/preadv2/preadv201.c
> @@ -111,6 +111,7 @@ static void cleanup(void)
>   }
>
>   static struct tst_test test = {
> +	.min_kver = "4.6",
>   	.tcnt = ARRAY_SIZE(tcases),
>   	.setup = setup,
>   	.cleanup = cleanup,
> diff --git a/testcases/kernel/syscalls/pwritev2/pwritev201.c b/testcases/kernel/syscalls/pwritev2/pwritev201.c
> index eba45b7d3..a8273e59d 100644
> --- a/testcases/kernel/syscalls/pwritev2/pwritev201.c
> +++ b/testcases/kernel/syscalls/pwritev2/pwritev201.c
> @@ -111,6 +111,7 @@ static void cleanup(void)
>   }
>
>   static struct tst_test test = {
> +	.min_kver = "4.6",
>   	.tcnt = ARRAY_SIZE(tcases),
>   	.setup = setup,
>   	.cleanup = cleanup,
> --
> 2.17.1
>
>

  reply	other threads:[~2021-03-30  8:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30  7:44 [LTP] [PATCH] min_kver: Add kernel version requestions Zhao Gongyi
2021-03-30  8:05 ` yangx.jy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-30  8:18 zhaogongyi
2021-03-30  8:58 ` yangx.jy
2021-03-30  9:31 zhaogongyi
2021-03-31  1:25 ` yangx.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6062DBD2.30501@fujitsu.com \
    --to=yangx.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox