From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] shmget02: fix EPERM test when RLIMIT_MEMLOCK is large enough
Date: Wed, 7 Jul 2021 02:36:21 +0000 [thread overview]
Message-ID: <60E51347.5000209@fujitsu.com> (raw)
In-Reply-To: <20210706132114.204443-1-cascardo@canonical.com>
Hi Thadeu
> shmget(..., SHM_HUGETLB) will not fail with EPERM if there is enough space
> for RLIMIT_MEMLOCK. If the limit is 0, it will fail with EPERM as expected
> when a not enough privileged user calls it.
>
> Set RLIMIT_MEMLOCK to 0 for all calls, as this is the only one which will
> fail because of that limit, unless we are talking about very old kernels
> (before 2.6.9).
>
> Fixes: 4dc493b44a85 ("syscalls/shmget*: Convert into new api")
> Signed-off-by: Thadeu Lima de Souza Cascardo<cascardo@canonical.com>
Thanks for the fix!
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
just a small nit: Since a child process created via fork(2) inherits its
parent's resource limits. I prefer to move it to setup function, so we
don't need to set it in each sub case.
Best Regards
Yang Xu
> ---
> testcases/kernel/syscalls/ipc/shmget/shmget02.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/ipc/shmget/shmget02.c b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> index 6be8d8157999..8857207cfd3d 100644
> --- a/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> +++ b/testcases/kernel/syscalls/ipc/shmget/shmget02.c
> @@ -64,6 +64,7 @@ static void do_test(unsigned int n)
> {
> struct tcase *tc =&tcases[n];
> pid_t pid;
> + struct rlimit rl = { 0, 0 };
>
> if (tc->exp_user == 0&& tc->exp_group == 0) {
> TST_EXP_FAIL2(shmget(*tc->shmkey, tc->size, tc->flags), tc->exp_err,
> @@ -78,6 +79,7 @@ static void do_test(unsigned int n)
> SAFE_SETGID(pw->pw_gid);
> }
> SAFE_SETUID(pw->pw_uid);
> + SAFE_SETRLIMIT(RLIMIT_MEMLOCK,&rl);
> TST_EXP_FAIL2(shmget(*tc->shmkey, tc->size, tc->flags), tc->exp_err,
> "shmget(%i, %lu, %i)", *tc->shmkey, tc->size, tc->flags);
> exit(0);
next prev parent reply other threads:[~2021-07-07 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 13:21 [LTP] [PATCH] shmget02: fix EPERM test when RLIMIT_MEMLOCK is large enough Thadeu Lima de Souza Cascardo
2021-07-07 2:36 ` xuyang2018.jy [this message]
2021-07-08 3:20 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60E51347.5000209@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox