Re: [LTP] [PATCH] perf_event_open03: Track SUnreclaim growth instead of MemAvailable

[Tang Yizhou <tangyeechou@gmail.com>]

On 21/7/26 9:40 pm, Cyril Hrubis wrote:
> Hi!
>> -	if ((sample > 5) || (diff_total > 100 * 1024))
>> -		tst_res(TFAIL, "Likely kernel memory leak detected, total decrease: %ld kB", diff_total);
>> -	else
>> +	if ((sample > 5) || (diff_total > 100 * 1024)) {
>> +		tst_res(TFAIL,
>> +			"Likely kernel memory leak detected, SUnreclaim increased by %ld kB total",
>> +			diff_total);
>> +		tst_res(TINFO,
>> +			"Unreclaimable slab can also grow due to memory activity from "
>> +			"any other unrelated process. If this test fails, re-run it on "
>> +			"an otherwise idle system and/or confirm with kmemleak "
>> +			"(CONFIG_DEBUG_KMEMLEAK) before treating it as a real regression.");
> 
> I wouldn't be that verbose here. Maybe something as:
> 
> 			"Unreclaimable slab can grow due to unrelated
> 			reasons as well. You can rerun the test with
> 			CONFIG_DEBUG_KMEMLEAK to make sure the leak is
> 			real.

OK. Will update in v2.

-- 
Best Regards,
Yi

> 
> Other than that:
> 
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> 
> 


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp