public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/madvise06: Add madvise WILLNEED performance problem tag
Date: Wed, 4 Aug 2021 01:23:12 +0000	[thread overview]
Message-ID: <6109EC1B.1040502@fujitsu.com> (raw)
In-Reply-To: <YQkpwAieJwTCzK+c@yuki>

Hi Cyril
> Hi!
>> diff --git a/testcases/kernel/syscalls/madvise/madvise06.c b/testcases/kernel/syscalls/madvise/madvise06.c
>> index 63d8d5452..f2f65ff96 100644
>> --- a/testcases/kernel/syscalls/madvise/madvise06.c
>> +++ b/testcases/kernel/syscalls/madvise/madvise06.c
>> @@ -35,6 +35,12 @@
>>    * faults. Two faults are allowed incase some tasklet or something
>>    * else unexpected, but irrelevant procedure, registers a fault to
>>    * our process.
>> + *
>> + * It also can reproduce the MADV_WILLNEED preformance problem.
>> + * It was introduced since 5.9 kernel with the following commit
>> + *   e6e88712e43b ("mm: optimise madvise WILLNEED")
>> + * and fixed since 5.10-rc5 kernel with the following commit
>> + *   66383800df9c ("mm: fix madvise WILLNEED performance problem").
>>    */
>>
>>   #include<errno.h>
>> @@ -242,6 +248,8 @@ static struct tst_test test = {
>>   	.tags = (const struct tst_tag[]) {
>>   		{"linux-git", "55231e5c898c"},
>>   		{"linux-git", "8de15e920dc8"},
>> +		{"linux-git", "e6e88712e43b"},
>> +		{"linux-git", "66383800df9c"},
>
> We only put patches that fixed the problem into the tags since we use
> these to print failure hints about missing kernel patches.
Oh, yes. Thanks for your review, I merged this patch with removing 
introduced patch tag.

Best Regards
Yang Xu
>
> Other than that it looks fine.
>
>>   		{}
>>   	}
>>   };
>> --
>> 2.23.0
>>
>>
>> --
>> Mailing list info: https://lists.linux.it/listinfo/ltp
>

      reply	other threads:[~2021-08-04  1:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  8:26 [LTP] [PATCH] syscalls/madvise06: Add madvise WILLNEED performance problem tag Yang Xu
2021-08-03 11:34 ` Cyril Hrubis
2021-08-04  1:23   ` xuyang2018.jy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6109EC1B.1040502@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox