From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] userns/userns08.c: Enable userns in max_user_namespaces file
Date: Tue, 31 Aug 2021 10:09:06 +0000 [thread overview]
Message-ID: <612DFFDE.5050800@fujitsu.com> (raw)
In-Reply-To: <87h7fbkwe8.fsf@suse.de>
Hi Richard
> Hello Yang,
>
> Yang Xu<xuyang2018.jy@fujitsu.com> writes:
>
>> On old distros ie centos7, the default value of max_user_namespaces is set to 0.
>> Enable it by increasing this value.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>
> Looks good, except for very minor point below.
>
> Reviewed-by: Richard Palethorpe<rpalethorpe@suse.com>
>
>> ---
>> testcases/kernel/containers/userns/userns08.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/testcases/kernel/containers/userns/userns08.c b/testcases/kernel/containers/userns/userns08.c
>> index aedfc6c4e..0910ea7d4 100644
>> --- a/testcases/kernel/containers/userns/userns08.c
>> +++ b/testcases/kernel/containers/userns/userns08.c
>> @@ -120,6 +120,11 @@ static void setup(void)
>>
>> SAFE_WRITE(fd, 1, "\n", 1);
>> SAFE_CLOSE(fd);
>> +
>> + /* The default value of max_user_namespaces is set to 0 on some distros,
>> + * We need to change the default value to call clone().
>> + */
>
> We don't need inline comments like this. In this case the commit message
> and git-blame is fine. Other times the style guide requests it goes in
> the comment at the top.
Thanks for your review. I have pushed the v2 patch with your
reviewed-by(increase this value in more userns cases.)
Best Regards
Yang Xu
>
prev parent reply other threads:[~2021-08-31 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 6:27 [LTP] [PATCH] userns/userns08.c: Enable userns in max_user_namespaces file Yang Xu
2021-08-18 9:57 ` xuyang2018.jy
2021-08-27 10:19 ` [LTP] [PATCH v2] testcases: " Yang Xu
2021-08-27 10:35 ` [LTP] [PATCH] userns/userns08.c: " Richard Palethorpe
2021-08-31 10:09 ` xuyang2018.jy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612DFFDE.5050800@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox