public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: "rpalethorpe@suse.de" <rpalethorpe@suse.de>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run
Date: Wed, 13 Oct 2021 08:15:17 +0000	[thread overview]
Message-ID: <61669595.3000900@fujitsu.com> (raw)
In-Reply-To: <87bl3t9zr3.fsf@suse.de>

Hi Richard
> Hello,
> 
> Yang Xu<xuyang2018.jy@fujitsu.com>  writes:
> 
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>>   scenario_groups/default | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/scenario_groups/default b/scenario_groups/default
>> index 439783dac..1dc2987d5 100644
>> --- a/scenario_groups/default
>> +++ b/scenario_groups/default
>> @@ -6,6 +6,7 @@ dio
>>   io
>>   mm
>>   ipc
>> +irq
>>   sched
>>   math
>>   nptl
>> -- 
>> 2.23.0
> 
> I'm not sure this should go in the default group at this time. The only
> test in irq (irqbalance), only works on some configurations. As
> discussed in the test review, the user must figure out if they should
> run it or not.

It is hard to say moving this case into default run at this time is good
or bad.

With an optimistic attitude, I want to add it into default run(add some
comment in irqbalance01.c that irqbalance01 may fail because it needs
some configuration in service or hardware)and then listen whether many
users complain about this failure.

ps: Many people still use runltp to test ltp instead of runltp-ng and
they usually only run default group. That is a important reason that I
want to add this case into default group.
> 
> Perhaps we need a new scenario group?
I don't have objection. So do you want to cover what scenario(advanced
or experimental scenario group)?

Best Regards
Yang Xu
> 

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-10-13  8:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13  1:14 [LTP] [PATCH 1/2] kernel/Makefile: Add irq to Makefile Yang Xu
2021-10-13  1:14 ` [LTP] [PATCH 2/2] scenario_groups/default: Add irq into default run Yang Xu
2021-10-13  4:24   ` Petr Vorel
2021-10-13  6:54   ` Richard Palethorpe
2021-10-13  8:15     ` xuyang2018.jy [this message]
2021-10-13 10:10       ` Cyril Hrubis
2021-10-14  0:56         ` xuyang2018.jy
2021-11-24 10:33           ` Petr Vorel
2021-10-13  4:19 ` [LTP] [PATCH 1/2] kernel/Makefile: Add irq to Makefile Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61669595.3000900@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox