Re: [LTP] [PATCH] bugfix for vmsplice/vmsplice02.c

["xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>]

Hi wen
> vmsplice/vmsplice02: Remove duplicate header files fcntl.h.
>
> Signed-off-by: Yehai Wen<wenyehai@huawei.com>
> ---
>   testcases/kernel/syscalls/vmsplice/vmsplice02.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/vmsplice/vmsplice02.c b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> index 39c407c..3dc623f 100644
> --- a/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> +++ b/testcases/kernel/syscalls/vmsplice/vmsplice02.c
> @@ -20,7 +20,6 @@
>   #include<sys/stat.h>
>   #include<fcntl.h>
>   #include<unistd.h>
> -#include<fcntl.h>
>   #include<sys/uio.h>
>   #include<limits.h>
Actually, lapi/fcntl.h has included fcntl.h, so the latter fcnlt.h also 
can be removed.

It looks ltp other places also exist this duplicate header files fcntl.h 
because of lapi/fcntl.h. I think we should remove fcntl.h for these 
cases when them use lapi/fcntl.h.

You can use "git grep "fcntl.h" " cmd to search them.


Best Regards
Yang Xu
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp