From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: LTP List <ltp@lists.linux.it>
Subject: [LTP] The problem of compression ratio calculation in zram01
Date: Tue, 14 Dec 2021 07:57:31 +0000 [thread overview]
Message-ID: <61B84E9B.2080306@fujitsu.com> (raw)
Hi
Before ltp commit 4372f7a2156 ("Fix compression ratio calculation in
zram01")[1], we used free -m changes to calculate the compression ratio.
After this patch, we used compr_data_size to calculate.
kernel documentation[2] has the following info:
orig_data_size: uncompressed size of data stored in this disk.
compr_data_size: compressed size of data stored in this disk
mem_used_total: the amount of memory allocated for this disk
IMO, this patch changes old test's purpose and we should use
mem_used_total field instead of compr_data_size(orig_data_size and
compr_data_size should be dynamic adjusted by system, so using it in
here is meaningless).
ps: If I understand wrong, please correct me.
[1]https://github.com/linux-test-project/ltp/commit/4372f7a215633e55f423dc09ec50650c142dca77
[2]https://www.kernel.org/doc/html/v5.3/admin-guide/blockdev/zram.html
Best Regards
Yang Xu
--
Mailing list info: https://lists.linux.it/listinfo/ltp
reply other threads:[~2021-12-14 7:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61B84E9B.2080306@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox