Re: [LTP] [PATCH v5 4/4] zram/zram01.sh: replacing data stored in this disk with allocated for this disk

["xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>]

Hi Petr
>> Before ltp commit 4372f7a2156 ("Fix compression ratio calculation in zram01")[1], we
> nit: we can drop [1]
>> used free -m changes to calculate the compression ratio.
>
>> After the above patch, we used compr_data_size to calculate. kernel documentation[2] has
> nit: I'd add link to the doc also in this commit message.
I don't see the link on your ltp fork:
https://github.com/pevik/ltp/tree/yang_xu/zram-swap.v5.fixes

I have tried this branch and these change seems fine.

I guess I don't need to send a v6 patch and you can merge it directly(by 
removing [1][2] linke and adding fixes tag ). Is it right?

ps: I want to add a fixes tag for pointing to commit 4372f7a2156 ("Fix 
compression ratio calculation in zram01").

Best Regards
Yang Xu
>
> Kind regards,
> Petr
>
>> the following info:
>> orig_data_size: uncompressed size of data stored in this disk.
>> compr_data_size: compressed size of data stored in this disk
>> mem_used_total: the amount of memory allocated for this disk
>
>> We should calculate the compression ratio by used disk size divided into used mem size.
>> It can also avoid the situation that division by 0 as below:
>> zram01 7 TINFO: filling zram4 (it can take long time)
>> zram01 7 TPASS: zram4 was filled with '25568' KB
>> zram01 7 TINFO: compr_size 0
>>   /opt/ltp/testcases/bin/zram01.sh: line 131: 100 * 1024 * 25568 / 0: division by 0 (error token is "0")
>
>> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp