From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem
Date: Wed, 12 Jan 2022 09:24:04 +0000 [thread overview]
Message-ID: <61DE9E69.1040509@fujitsu.com> (raw)
In-Reply-To: <Yd6R0Th45Y1NLqTN@yuki>
Hi Cyril
> Hi!
>>> Ah, that's what I have missed. But still, what happen if we pass fd to a
>>> regular file to the quotactl_fd()? Shouldn't we test that case too?
>> Good suggestion.
>> Yes, AFAIK, the fd point to superblock, every subcmd will check quota
>> feature bit or whether enable but return different errno.
>>
>> I will test Q_QUOTAON with regular file fd because it is the most
>> meaningful.
>
> And we can always try to pass a fd pointing to a socket, that shouldn't
> be associated with any block device at all.
Yes, my old way use external fd deponds on tmp environmet(ie use
xfs,ext4 with quota or with quota feature) and it make test unstable.
If using socket fd, it should report ENOSYS.
Best Regards
Yang Xu
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-01-12 9:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:54 [LTP] [PATCH v3 06/12] lapi/quotactl.h: Add fallback for quotactl_fd Yang Xu
2021-11-09 10:54 ` [LTP] [PATCH v3 07/12] syscalls/quotactl08: Test quoatctl01 but quota info hidden in filesystem Yang Xu
2021-11-10 16:32 ` Cyril Hrubis
2021-11-11 8:48 ` xuyang2018.jy
2021-11-11 14:30 ` Cyril Hrubis
2021-11-26 9:32 ` xuyang2018.jy
2021-12-13 7:26 ` [LTP] [PATCH v4 1/6] " Yang Xu
2021-12-13 7:26 ` [LTP] [PATCH v4 2/6] syscalls/quotactl02, 5: Add quotactl_fd test variant Yang Xu
2022-01-07 14:30 ` Cyril Hrubis
2021-12-13 7:26 ` [LTP] [PATCH v4 3/6] syscalls/quotactl03: " Yang Xu
2022-01-07 14:59 ` Cyril Hrubis
2021-12-13 7:26 ` [LTP] [PATCH v4 4/6] syscalls/quotactl04: " Yang Xu
2022-01-07 15:35 ` Cyril Hrubis
2022-01-10 10:09 ` xuyang2018.jy
2021-12-13 7:26 ` [LTP] [PATCH v4 5/6] syscalls/quotactl09: Test error when quota info hidden in filesystem Yang Xu
2022-01-07 15:50 ` Cyril Hrubis
2022-01-10 6:48 ` xuyang2018.jy
2022-01-10 14:46 ` Cyril Hrubis
2022-01-11 6:51 ` xuyang2018.jy
2022-01-11 10:55 ` Cyril Hrubis
2022-01-12 1:52 ` xuyang2018.jy
2022-01-12 8:31 ` Cyril Hrubis
2022-01-12 9:24 ` xuyang2018.jy [this message]
2021-12-13 7:26 ` [LTP] [PATCH v4 6/6] syscalls/quotactl07: Add quotactl_fd test variant Yang Xu
2022-01-07 16:03 ` Cyril Hrubis
2022-01-10 9:03 ` xuyang2018.jy
2021-12-23 8:03 ` [LTP] [PATCH v4 1/6] syscalls/quotactl08: Test quoatctl01 but quota info hidden in filesystem xuyang2018.jy
2022-01-07 14:09 ` Cyril Hrubis
2022-01-10 6:37 ` xuyang2018.jy
2022-01-10 14:46 ` Cyril Hrubis
2021-11-09 10:54 ` [LTP] [PATCH v3 08/12] syscalls/quotactl02, 5: Add quotactl_fd test variant Yang Xu
2021-11-09 10:54 ` [LTP] [PATCH v3 09/12] syscalls/quotactl03: " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61DE9E69.1040509@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox