Re: [LTP] [RFC PATCH 1/1] lib: Print in summary also tests not run at all

["xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>]

Hi Petr
> We count only tests which TCONF. In case tst_brk() some tests might be
> skipped without even trying to run them), thus print them.
>
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> Hi,
>
> probably quite confusing to have "skipped" and "not run".
> Maybe rename s/skipped/cancelled/ and s/not run/skipped/ ?
> Or just to increase cound of skipped?
>
> E.g. instead of:
>
> bind05.c:132: TCONF: socket(10, 2, 0) failed: EAFNOSUPPORT (97)
>
> Summary:
> passed   8
> failed   0
> broken   0
> skipped  1
> warnings 0
> not run  5
>
> have
> bind05.c:132: TCONF: socket(10, 2, 0) failed: EAFNOSUPPORT (97)
>
> Summary:
> passed   8
> failed   0
> broken   0
> skipped  6
> warnings 0
>
> Kind regards,
> Petr
>
>   lib/tst_test.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 844756fbd7..e5ea9e6165 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -811,6 +811,9 @@ static void do_exit(int ret)
>   		fprintf(stderr, "broken   %d\n", results->broken);
>   		fprintf(stderr, "skipped  %d\n", results->skipped);
>   		fprintf(stderr, "warnings %d\n", results->warnings);
> +		fprintf(stderr, "not run  %d\n", tst_test->tcnt -
> +				results->passed - results->failed - results->broken -
> +				results->skipped - results->warnings);
IMO, these values are not necessary related. Refer to quotactl01.c( 
tst_test->tcnt is less than results->passed)

Also, if you want to add a new tag, you should define the situation for it.

Best Regards
Yang Xu

>   	}
>
>   	do_cleanup();

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp