From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Bogdan Lezhepekov <bogdan.lezhepekov@suse.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel
Date: Fri, 11 Feb 2022 08:30:13 +0000 [thread overview]
Message-ID: <62061EC1.2040206@fujitsu.com> (raw)
In-Reply-To: <VI1PR04MB49587421680CE7C6AA8599CD93309@VI1PR04MB4958.eurprd04.prod.outlook.com>
Hi Bogdan
> Hi all,
>
> I didn't go for CONFIG_SWAP just because wanted to be aligned with
> syscalls/swapon/swapon03.c and to not multiply patterns.
>
> If you see CONFIG_SWAP more beneficial for docparser, I can make another
> patch.
>
> Should I?
IMO, yes, but let's listen voice from other maintainers.
@Petr,@Cyril
Best Regards
Yang Xu
>
> Cheers,
> Bogdan
> ------------------------------------------------------------------------
> *From:* ltp <ltp-bounces+bogdan.lezhepekov=suse.com@lists.linux.it> on
> behalf of xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
> *Sent:* Friday, February 11, 2022 3:21
> *To:* Li Wang <liwang@redhat.com>
> *Cc:* LTP List <ltp@lists.linux.it>
> *Subject:* Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is
> supported by kernel
> Hi Li
>>
>>
>> On Fri, Feb 11, 2022 at 12:09 AM Cyril Hrubis <chrubis@suse.cz
>> <mailto:chrubis@suse.cz>> wrote:
>>
>> Hi!
>> Applied, thanks.
>>
>> I guess that the SAFE_OPEN() caused TBROK on machines without
>> CONFIG_SWAP, right?
>>
>>
>> If so, why not go fix with .needs_config for "CONFIG_SWAP=y" ?
> +1, it is also friendly to docparse.
>
> ps: I never listen user complaint for the lack of CONFIG_PORC, so only
> using .needs_config for "CONFIG_SWAP=y" can work well.
>
> Best Regards
> Yang Xu
>>
>> --
>> Regards,
>> Li Wang
>>
>>
>>
>>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-11 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 13:38 [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel Bogdan Lezhepekov via ltp
2022-02-10 16:11 ` Cyril Hrubis
2022-02-10 16:30 ` Bogdan Lezhepekov via ltp
2022-02-11 0:39 ` Li Wang
2022-02-11 1:21 ` xuyang2018.jy
2022-02-11 7:35 ` Bogdan Lezhepekov via ltp
2022-02-11 8:30 ` xuyang2018.jy [this message]
2022-02-11 8:59 ` Petr Vorel
2022-02-11 13:15 ` Cyril Hrubis
2022-02-11 13:16 ` Bogdan Lezhepekov via ltp
2022-02-12 2:19 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62061EC1.2040206@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=bogdan.lezhepekov@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox