From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 5/5] syscalls/pidfd_getfd02: add basic error test
Date: Fri, 18 Feb 2022 07:03:09 +0000 [thread overview]
Message-ID: <620F44D6.1070908@fujitsu.com> (raw)
In-Reply-To: <Yg9Bs81ZehfgFZ38@pevik>
Hi Petr
> Hi Xu,
>
>>> and get more info.
>> I will look Cyril's patch and wait.
> Thx!
The Cyril's patch seems only a single patch and doesn't affect the other
TST_TEST macros. So how I just only use
TST_EXP_FD_SILENT(pidfd_open(getpid(), 0));?
>
>>>> + if (!TST_PASS)
>>>> + tst_brk(TFAIL | TTERRNO, "pidfd_open failed");
>
>>> @Cyril: would it be possible to to allow using also tst_brk() in macros in
>>> tst_test_macros.h?
>
>> Maybe can add SAFE_PIDFD_OPEN.
> I was thinking about it. But you use TFAIL - part of testing.
> But using just SAFE_PIDFD_OPEN() even it's using TBROK might be best.
My v2 just keep this.
ps: I also remove useless static expire_pidfd because we can use TST_RET
as pidfd when tesing ESRCH error.
Best Regards
Yang Xu
>
> Kind regards,
> Petr
>
>>> Having TST_*_BRK() (i.e. TST_EXP_FD_SILENT_BRK()) looks too complicated
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-18 7:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:04 [LTP] [PATCH 1/5] kcmp.h: move it to ltp include/lapi directory Yang Xu
2022-02-16 10:04 ` [LTP] [PATCH 2/5] lapi/kcmp.h: Replace GPL with SPDX-License-Identifier Yang Xu
2022-02-16 14:05 ` Petr Vorel
2022-02-17 18:52 ` Petr Vorel
2022-02-18 2:13 ` xuyang2018.jy
2022-02-18 8:28 ` Petr Vorel
2022-02-16 10:04 ` [LTP] [PATCH 3/5] pidfd_getfd.h: add fallback Yang Xu
2022-02-16 14:09 ` Petr Vorel
2022-02-18 2:14 ` xuyang2018.jy
2022-02-16 10:04 ` [LTP] [PATCH 4/5] Add pidfd_getfd01 test Yang Xu
2022-02-17 19:20 ` Petr Vorel
2022-02-18 3:24 ` xuyang2018.jy
2022-02-18 7:02 ` Petr Vorel
2022-02-21 10:03 ` Richard Palethorpe
2022-02-21 12:42 ` Petr Vorel
2022-02-21 13:49 ` Richard Palethorpe
2022-02-18 8:57 ` Petr Vorel
2022-02-18 9:56 ` xuyang2018.jy
2022-02-18 10:15 ` Petr Vorel
2022-02-22 2:29 ` xuyang2018.jy
2022-02-17 19:28 ` Petr Vorel
2022-02-18 3:37 ` xuyang2018.jy
2022-02-18 6:59 ` Petr Vorel
2022-02-16 10:04 ` [LTP] [PATCH 5/5] syscalls/pidfd_getfd02: add basic error test Yang Xu
2022-02-17 19:56 ` Petr Vorel
2022-02-18 3:49 ` xuyang2018.jy
2022-02-18 6:50 ` Petr Vorel
2022-02-18 7:03 ` xuyang2018.jy [this message]
2022-02-18 10:58 ` Petr Vorel
2022-02-22 2:49 ` xuyang2018.jy
2022-02-16 14:02 ` [LTP] [PATCH 1/5] kcmp.h: move it to ltp include/lapi directory Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620F44D6.1070908@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox