ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Martin Doucha <mdoucha@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] syscalls/setsockopt09: Add another linux git
Date: Wed, 9 Mar 2022 02:03:04 +0000	[thread overview]
Message-ID: <62280B08.3010502@fujitsu.com> (raw)
In-Reply-To: <3c946010-2f96-e8bb-e7ee-0d48d482d729@suse.cz>

Hi Martin
> On 04. 03. 22 4:24, xuyang2018.jy@fujitsu.com wrote:
>> Hi Petr
>>> Hi Xu,
>>>
>>>> On centos7.9ga, I still hit another crash problem because of use-after-free in
>>>> prb_retire_rx_blk_timer_expired(). Since we free it when timer expired, so this
>>>> case will crash after we print TPASS info.
>>>
>>> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>>>
>>> LGTM.
>>> I tested two old kernels, the one with patch survives, the other got reboot.
>>>
>>> BTW funny enough the affected system manages to print "TPASS: Nothing bad
>>> happened, probably" before reboot :).
>> Yes, it crash when timer expired, so it will print TPASS before reboot.
>> Also, I try sleep 10ms, but it still print TPASS and reboot after serval
>> seconds.
>
> The timeout is controlled by req.tp_retire_blk_tov and the value is in
> milliseconds. So usleep(req.tp_retire_blk_tov * 3000) should be enough.
I tested this on my vm, it still can't ensure hit the old crash before 
print PASS log.

Best Regards
Yang Xu
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-09  2:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  8:54 [LTP] [PATCH] syscalls/setsockopt09: Add another linux git Yang Xu
2022-03-03  9:11 ` xuyang2018.jy
2022-03-03 14:04 ` Petr Vorel
2022-03-04  3:24   ` xuyang2018.jy
2022-03-04  8:01     ` Petr Vorel
2022-03-08 10:04       ` xuyang2018.jy
2022-03-08 10:44     ` Martin Doucha
2022-03-09  2:03       ` xuyang2018.jy [this message]
2022-03-09 10:51         ` Martin Doucha
2022-03-10  6:07           ` xuyang2018.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62280B08.3010502@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).