Linux Test Project
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Li Wang <liwang@redhat.com>
Cc: Bruno Goncalves <bgoncalv@redhat.com>,
	"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 2/3] lib: enhance .save_restore to support set expected value
Date: Thu, 10 Mar 2022 07:43:05 +0000	[thread overview]
Message-ID: <6229AC3C.2040608@fujitsu.com> (raw)
In-Reply-To: <20220309030440.4166954-2-liwang@redhat.com>

Hi Li
>
> diff --git a/include/tst_test.h b/include/tst_test.h
> index 816fab4dd..e514efa76 100644
> --- a/include/tst_test.h
> +++ b/include/tst_test.h
> @@ -259,7 +259,7 @@ struct tst_test {
>   	 * NULL terminated array of (/proc, /sys) files to save
>   	 * before setup and restore after cleanup
>   	 */
> -	const char * const *save_restore;
> +	const struct tst_path_val const *save_restore;
Ci complains about duplicate const see the following url
https://github.com/linux-test-project/ltp/runs/5491806027?check_suite_focus=true#step:10:19

How about using const struct tst_path_val *save_restore like
other struct pointer( struct tst_cap *caps, const struct tst_tag *tags)?

Best Regards
Yang Xu

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-03-10  7:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  7:37 [LTP] [PATCH 0/4] enhance .save_restore to support set value Li Wang
2022-03-08  7:37 ` [LTP] [PATCH 1/4] lib: move struct tst_sys_conf to internal Li Wang
2022-03-08 12:25   ` Cyril Hrubis
2022-03-08  7:37 ` [LTP] [PATCH 2/4] lib: enhance .save_restore to support set expected value Li Wang
2022-03-08 13:02   ` Cyril Hrubis
2022-03-09  2:27     ` Li Wang
2022-03-08  7:37 ` [LTP] [PATCH 3/4] testcase: switch to the new .save_restore Li Wang
2022-03-08 13:05   ` Cyril Hrubis
2022-03-08  7:37 ` [LTP] [PATCH 4/4] ksm: cleanup work and make use of .save_restore Li Wang
2022-03-08 13:20   ` Cyril Hrubis
2022-03-09  3:04 ` [LTP] [PATCH v2 1/3] lib: move struct tst_sys_conf to internal Li Wang
2022-03-09  3:04   ` [LTP] [PATCH v2 2/3] lib: enhance .save_restore to support set expected value Li Wang
2022-03-09 10:00     ` Cyril Hrubis
2022-03-10  1:26       ` Li Wang
2022-03-10  7:43     ` xuyang2018.jy [this message]
2022-03-10  7:53       ` Li Wang
2022-03-10  8:01         ` xuyang2018.jy
2022-03-09  3:04   ` [LTP] [PATCH v2 3/3] ksm: cleanup work and make use of .save_restore Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6229AC3C.2040608@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=bgoncalv@redhat.com \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox