Linux Test Project
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>,
	"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] quotactl: Check for missing quota_v2 module
Date: Tue, 15 Mar 2022 01:27:24 +0000	[thread overview]
Message-ID: <622FEBAA.2020706@fujitsu.com> (raw)
In-Reply-To: <Yi9Cx1DTJi3nxxUd@pevik>

Hi Petr
> Hi Martin, Xu,
>
> I wonder whether quotactl04 still needs check for ESRCH search in do_mount()
> implemented by Martin in 4aab31e4c7 ("syscalls/quotactl: Skip tests if FS quota
> is not supported"), because that could be caught by CONFIG_QFMT_V2 and now
> quota_v2, right?
I think it is right.
>
> It uses fs_opts[] = {"-I 256", "-O quota,project", NULL} parameters for mkfs,
> thus it is probably needed.
If we format ext4 filesystem with quota feature, then the quota 
information will hidden in filesystem instead of visible file by using 
quotacheck.

But this feature needs mkfs > 1.43.0.

I guess we can remove do_mount by using SAFE_MOUNT like quotactl08 did.

Best Regards
Yang Xu

But shouldn't it be used also in quotactl08, which
> also uses fs_opts[] = { "-O quota", NULL} ?
>
> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-15  1:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 13:02 [LTP] [PATCH 1/1] quotactl: Check for missing quota_v2 module Petr Vorel
2022-03-14 13:27 ` Petr Vorel
2022-03-15  1:27   ` xuyang2018.jy [this message]
2022-03-15  1:31 ` xuyang2018.jy
2022-03-15  9:16   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=622FEBAA.2020706@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox