From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] syscalls/umount2_02: remove useless TST_ERR assignment
Date: Mon, 28 Mar 2022 05:30:20 +0000 [thread overview]
Message-ID: <62414819.2010802@fujitsu.com> (raw)
In-Reply-To: <Yj2WSuxQ583m3uQG@pevik>
Hi Petr,Dai
> Hi Dai,
>
>> Signed-off-by: Dai Shili<daisl.fnst@fujitsu.com>
>> ---
>> testcases/kernel/syscalls/umount2/umount2_02.c | 1 -
>> 1 file changed, 1 deletion(-)
>
>> diff --git a/testcases/kernel/syscalls/umount2/umount2_02.c b/testcases/kernel/syscalls/umount2/umount2_02.c
>> index 4c3b30e..d1aed11 100644
>> --- a/testcases/kernel/syscalls/umount2/umount2_02.c
>> +++ b/testcases/kernel/syscalls/umount2/umount2_02.c
>> @@ -69,7 +69,6 @@ static int umount2_retry(const char *target, int flags)
>> tst_res(TWARN, "Failed to umount('%s', %i) after 50 retries",
>> target, flags);
>
>> - TST_ERR = EBUSY;
>
> Not sure if the for loop in umount2_retry() could overwrite the original errno.
IMO, in this wrapper, we don't need to use TEST macro and we can use
umount2 directly.
Best Regards
Yang Xu
>
> Kind regards,
> Petr
>
>> return -1;
>> }
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-28 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 21:22 [LTP] [PATCH] syscalls/umount2_02: remove useless TST_ERR assignment Dai Shili
2022-03-25 10:15 ` Petr Vorel
2022-03-28 5:30 ` xuyang2018.jy [this message]
2022-03-28 7:12 ` Petr Vorel
2022-03-28 19:56 ` [LTP] [PATCH] syscalls/umount2_02: use umount2 directly instead of TEST macro Dai Shili
2022-03-28 9:26 ` xuyang2018.jy
2022-03-30 6:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62414819.2010802@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox