[LTP] [PATCH] mem/oom: fork may fail before test

[LTP] [PATCH] mem/oom: fork may fail before test

[Jan Stancek]

On systems with small RAM and vm.overcommit_memory == 2,
the system may already be in state where Committed_AS is
larger than CommitLimit due to various backround daemons
(NM, tuned, polkitd,...) asking for big allocations.

In such instances oom testcases report TBROK on very first fork.
This patch allows this to be a valid outcome (TPASS).

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/mem/lib/mem.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
index c55a55d57915..3d853a393d28 100644
--- a/testcases/kernel/mem/lib/mem.c
+++ b/testcases/kernel/mem/lib/mem.c
@@ -127,6 +127,10 @@ void oom(int testcase, int lite, int retcode, int allow_sigkill)
 
 	switch (pid = fork()) {
 	case -1:
+		if (errno == retcode) {
+			tst_resm(TPASS | TERRNO, "fork");
+			return;
+		}
 		tst_brkm(TBROK | TERRNO, cleanup, "fork");
 	case 0:
 		threads = MAX(1, tst_ncpus() - 1);
-- 
1.8.3.1

[LTP] [PATCH] mem/oom: fork may fail before test

[Cyril Hrubis]

Hi!
> On systems with small RAM and vm.overcommit_memory == 2,
> the system may already be in state where Committed_AS is
> larger than CommitLimit due to various backround daemons
> (NM, tuned, polkitd,...) asking for big allocations.
> 
> In such instances oom testcases report TBROK on very first fork.
> This patch allows this to be a valid outcome (TPASS).

Looks good to me, acked.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] mem/oom: fork may fail before test

[Jan Stancek]

----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Monday, 23 May, 2016 4:36:11 PM
> Subject: Re: [LTP] [PATCH] mem/oom: fork may fail before test
> 
> Hi!
> > On systems with small RAM and vm.overcommit_memory == 2,
> > the system may already be in state where Committed_AS is
> > larger than CommitLimit due to various backround daemons
> > (NM, tuned, polkitd,...) asking for big allocations.
> > 
> > In such instances oom testcases report TBROK on very first fork.
> > This patch allows this to be a valid outcome (TPASS).
> 
> Looks good to me, acked.

Pushed.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
>