From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH] tst_taint: TCONF when kernel is alreay tainted
Date: Tue, 15 Oct 2019 10:00:27 -0400 (EDT) [thread overview]
Message-ID: <679691068.6290837.1571148027820.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190919100205.GA26642@rei>
----- Original Message -----
> Hi!
> > As the tst_taint_init comments described, If the tainted-flags are already
> > set
> > by the kernel, there is no reason to continue and TCONF is generated. But
> > in
> > the function achieve, it uses TBROK.
> >
> > cmdline="cve-2017-17053"
> > tst_test.c:1096: INFO: Timeout per run is 0h 10m 00s
> > tst_taint.c:88: BROK: Kernel is already tainted: 536871424
>
> There is a reason for generating TBROK, we do not want the test to be
> skipped silently in this case.
It can still run and maybe trigger worse problem. IMO if test wants
to report taint flags it should only report _new_ taint flags.
We could add a dummy test to end of runtest file, which would check
selected taint flags and report WARN/FAIL, so they are guaranteed
to appear on report.
Regards,
Jan
next prev parent reply other threads:[~2019-10-15 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 5:35 [LTP] [RFC PATCH] tst_taint: TCONF when kernel is alreay tainted Li Wang
2019-09-18 5:56 ` Li Wang
2019-09-19 10:02 ` Cyril Hrubis
2019-09-20 3:00 ` Li Wang
2019-10-15 14:00 ` Jan Stancek [this message]
2019-10-15 14:38 ` Cyril Hrubis
2019-10-15 15:19 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=679691068.6290837.1571148027820.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox