Re: [LTP] [PATCH v2] securebits: some cleanup

Cyril Hrubis
2014-10-15T11:32:52Z

Hi!
> # ./check_keepcaps 1
> keepcaps 0 TWARN : tst_brk_: Invalid Type: 0. Using TBROK
> keepcaps 1 TBROK : check_keepcaps.c:88: dropped privs as expected
>
> from lib/tst_res.c:
> /*
> * Only FAIL, BROK, CONF, and RETR are supported by tst_brk().
> */

When I was looking at the tst interface this looked to me like an
artificial limitation. I guess that we can introduce an function that
would report success and exit the test as well, the only complicated
part would be figuring out good name.

And more progressive view may be that we need two functions for
reporting results. One that just reports the result and one that also
exit the test execution (and calls an optional cleanup callback). But
that would require more changes in the test library and in testscases.
And I do not want to add an unfamiliar interface as well.

--
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.