Re: [LTP] [PATCH v2] securebits: some cleanup

Zeng Linggang
2014-10-08T07:24:11Z

Hi, Jan
On Fri, 2014-09-26 at 08:43 -0400, Jan Stancek wrote:
>
>
>
> ----- Original Message -----
> > From: "Zeng Linggang" <zenglg.jy@cn.fujitsu.com>
> > To: "Jan Stancek" <jstancek@redhat.com>
> > Cc: "ltp-list" <ltp-list@lists.sourceforge.net>
> > Sent: Friday, 26 September, 2014 10:06:57 AM
> > Subject: [PATCH v2] securebits: some cleanup
> >
> > * Remove .sh and divide into three seperate tests.
> >
> > * Check the header <linux/securebits.h>.
> >
> > * Use tst_brkm instead of tst_exit() that follows tst_resm.
> >
> > * Some cleanup
> >
> > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
>
> Is the modified testcase working for you?
>

I am so sorry for that I made a stupid mistake.
My intention is to print pass and exit the test, but I use
tst_brkm(TPASS, ..) that make us get a segmentation fault.
I will fix it.
Thank you very much.

Best regards,
Zeng

> I'm getting segmentation fault:
>
> (gdb) bt
> #0 __GI__IO_fputs (str=str@entry=0x7fffffffa980 "keepcaps 0 TWARN : tst_brk_: Invalid Type: 0. Using TBROK\n", fp=0x0)
> at iofputs.c:39
> #1 0x00000000004015ee in tst_print (tcid=0x4029ba "keepcaps", tnum=tnum@entry=0, ttype=ttype@entry=4,
> tmesg=tmesg@entry=0x605240 <Warn_mesg> "tst_brk_: Invalid Type: 0. Using TBROK") at tst_res.c:479
> #2 0x00000000004021f5 in tst_brk_ (file=file@entry=0x4028fe "check_keepcaps.c", lineno=lineno@entry=88, ttype=ttype@entry=0,
> fname=fname@entry=0x0, func=func@entry=0x0, arg_fmt=arg_fmt@entry=0x402ac6 "%s") at tst_res.c:656
> #3 0x00000000004026a8 in tst_brkm_ (file=file@entry=0x4028fe "check_keepcaps.c", lineno=lineno@entry=88, ttype=ttype@entry=0,
> func=func@entry=0x0, arg_fmt=arg_fmt@entry=0x402926 "dropped privs as expected") at tst_res.c:769
> #4 0x0000000000401460 in do_setuid (expect_privs=expect_privs@entry=0) at check_keepcaps.c:88
> #5 0x000000000040124f in main (argc=2, argv=0x7fffffffe528) at check_keepcaps.c:113
>
> and when I fix the crash (T_out is uninitialized) I get:
>
> # ./check_keepcaps 1
> keepcaps 0 TWARN : tst_brk_: Invalid Type: 0. Using TBROK
> keepcaps 1 TBROK : check_keepcaps.c:88: dropped privs as expected
>
> from lib/tst_res.c:
> /*
> * Only FAIL, BROK, CONF, and RETR are supported by tst_brk().
> */
>
> Regards,
> Jan