From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] syscalls/madvise09: Fix for disabled swap accounting
Date: Wed, 3 May 2017 04:14:30 -0400 (EDT) [thread overview]
Message-ID: <696452069.6330211.1493799270469.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170502133329.9913-1-chrubis@suse.cz>
----- Original Message -----
> The test had to be fixed for systems with swap accounting disabled.
>
> First there are no "memsw" prefixed tuning knobs in memcg directories if
> swap accounting is disabled.
>
> Then we had to limit the hungry child since otherwise it will be killed
> only after all system swap was filled. Hence we exit the memory hungry
> child once the process fills 100MB of swap. That seems to be enough to
> put the cgroup into memory pressure while it limits the test runtime to
> a few seconds.
Looks reasonable to me, only 2 alternatives I can think of is turning
off swap for duration of test, or exit with TCONF if swap accounting
is disabled.
Regards,
Jan
next prev parent reply other threads:[~2017-05-03 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 13:33 [LTP] [RFC] [PATCH] syscalls/madvise09: Fix for disabled swap accounting Cyril Hrubis
2017-05-03 8:14 ` Jan Stancek [this message]
2017-05-03 8:18 ` Cyril Hrubis
2017-05-05 9:09 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696452069.6330211.1493799270469.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox