Re: [LTP] [Automated-testing] [PATCH 0/5] network: cleanup stress tests

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

> > This is a huge change. Did you verify tests one by one? I can trust this
> > patch-set but we really don't want to remove anything that might be used
> > by people at the moment.
> 
> FYI none of these tests is in any runtest file.
> 
> And I expect nobody is actually using them nowadays because all these tests
> require 'rsh' via check_envval script:
> 
> exists cut locale rsh
> 
> > There network testing suite is indeed quite complex and ugly, so you will
> > have my approval if you think we don't need it anymore.
> 
> Maybe some of them have useful test scenario, but they seem to me just checking
> if kernel crashes when sending packet on TCP/UDP/ICMP/various IPsec. And because
> we have better tests covering IPsec over various protocols including TCP and UDP
> I don't think they are actually worth of cleanup.
> 
> Kind regards,
> Petr

Thanks for explaining, feel free to remove then.

Acked-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp