Re: [LTP] [PATCH v2 5/5] syscalls: add listns02 functionality test

Cyril Hrubis
2026-03-20T11:20:07Z

Hi!
> + if (TST_RET < 0) {
> + tst_res(TFAIL | TTERRNO, "listns() failed for %s", tc->desc);
> + return;
> + }
> +
> + found = 0;
> + for (int i = 0; i < TST_RET; i++) {
> + tst_res(TDEBUG, "buf[%d] = %lu", i, buf[i]);
^
I would say that this is a bit
cryptic.

If we want have debugging output I would add something as:

tst_res(TDEBUG, "Looking for nsid=%lu", ns_id);

for (int i ...) {
tst_res(TDEBUG, "list %i. nsid=%lu", i, buf[i]);

}

Otherwise it looks good:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

--
Cyril Hrubis
chrubis@suse.cz