Re: [LTP] [PATCH v2] userfaultfd: Minor fixes

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Ricardo,

> 
> On 3/26/26 9:38 AM, Andrea Cervesato wrote:
> > Hi ricardo,
> >
> >> +	if (page) {
> >> +		SAFE_MUNMAP(page, page_size);
> >> +		SAFE_MUNMAP(copy_page, page_size);
> >> +		page = NULL;
> >> +	}
> > This is gonna TBROK when copy_page is NULL. The same apply to all other
> > tests which are affected by the same bug.
> 
> Fixed in v3.
> 
> BTW, we have a minor difference in tests:
> 
> $ diff userfaultfd03.c userfaultfd06.c
> 
> <         tst_brk(TBROK | TERRNO, "Received unexpected UFFD_EVENT %d", 
> msg.event);
> ---
>  >         tst_brk(TFAIL, "Received unexpected UFFD_EVENT %d", msg.event);
> 
> I think we should have TFAIL, WDYT?

It depends on the subject of our test and both tests are actually testing
other features than the specific uffd_msg attributes when an event is
recevied. For this reason I would keep TBROK in both of them.

I see that also userfaultfd05 has the same issue. I don't remember the full
conversation before merging the patches, but if none mentioned a reason in
there, the tests will need to be adapted.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp