From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Ricardo Branco" <rbranco@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] userfaultfd: Minor fixes
Date: Mon, 30 Mar 2026 07:58:06 +0000 [thread overview]
Message-ID: <69ca2d0e.050a0220.155f63.a4e7@mx.google.com> (raw)
In-Reply-To: <20260327160157.76906-1-rbranco@suse.de>
Hi!
> if (msg.event != UFFD_EVENT_PAGEFAULT)
> - tst_brk(TFAIL, "Received unexpected UFFD_EVENT %d", msg.event);
> + tst_brk(TFAIL | TERRNO, "Received unexpected UFFD_EVENT %d", msg.event);
Looking closer..
TERRNO here is not needed. At this point SAFE_READ() passed and we are going
to print the errno from a previous failing call (most probably from a previous
`-i` iteration) if we receive the wrong event.
We can fix before merge if other accept this review.
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-03-30 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 16:01 [LTP] [PATCH v3] userfaultfd: Minor fixes Ricardo Branco
2026-03-30 7:24 ` Petr Vorel
2026-03-30 10:15 ` Cyril Hrubis
2026-03-30 10:42 ` Petr Vorel
2026-03-30 7:58 ` Andrea Cervesato via ltp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69ca2d0e.050a0220.155f63.a4e7@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=rbranco@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox