From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Wei Gao" <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v8 2/2] open16: allow restricted O_CREAT of FIFOs and regular files
Date: Wed, 06 May 2026 13:16:03 +0000 [thread overview]
Message-ID: <69fb3f13.5d0a0220.d655e.1133@mx.google.com> (raw)
In-Reply-To: <20260416005603.22427-3-wegao@suse.com>
Hi Wei,
> +
> + if (n == 2) {
> + SAFE_CHOWN(DIR, -1, gid1);
> + SAFE_CHMOD(DIR, 0030 | S_ISVTX);
> + } else {
> + SAFE_CHOWN(DIR, 0, 0);
> + SAFE_CHMOD(DIR, 0777 | S_ISVTX);
> + }
This is not convincing me. We should probably add these values inside the
tcase struct and use a canary value for excluding SAFE_CHOWN/CHMOD from
being used.
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-06 13:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 11:20 [LTP] [PATCH v1] open15: allow restricted O_CREAT of FIFOs and regular files Wei Gao via ltp
2023-12-08 15:34 ` Cyril Hrubis
2023-12-27 13:05 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-02-26 13:37 ` Cyril Hrubis
2024-06-03 12:55 ` [LTP] [PATCH v3] " Wei Gao via ltp
2025-02-21 10:01 ` Andrea Cervesato via ltp
2025-03-19 14:23 ` [LTP] [PATCH v4] open16: " Wei Gao via ltp
2025-07-11 12:04 ` Cyril Hrubis
2025-07-23 15:46 ` [LTP] [PATCH v5] " Wei Gao via ltp
2026-02-18 13:21 ` Andrea Cervesato via ltp
2026-04-15 6:07 ` [LTP] [PATCH v6 0/2] " Wei Gao via ltp
2026-04-15 6:07 ` [LTP] [PATCH v6 1/2] lib: New library function tst_get_free_uid Wei Gao via ltp
2026-04-15 7:54 ` [LTP] " linuxtestproject.agent
2026-04-15 6:07 ` [LTP] [PATCH v6 2/2] open16: allow restricted O_CREAT of FIFOs and regular files Wei Gao via ltp
2026-04-15 10:37 ` [LTP] [PATCH v6 0/2] " Wei Gao via ltp
2026-04-15 10:37 ` [LTP] [PATCH v7 1/2] lib: New library function tst_get_free_uid Wei Gao via ltp
2026-04-15 11:08 ` [LTP] " linuxtestproject.agent
2026-04-16 0:55 ` [LTP] [PATCH v8 0/2] open16: allow restricted O_CREAT of FIFOs and regular files Wei Gao via ltp
2026-04-16 0:55 ` [LTP] [PATCH v8 1/2] lib: New library function tst_get_free_uid Wei Gao via ltp
2026-04-16 2:43 ` [LTP] " linuxtestproject.agent
2026-04-16 4:15 ` Wei Gao via ltp
2026-04-16 0:55 ` [LTP] [PATCH v8 2/2] open16: allow restricted O_CREAT of FIFOs and regular files Wei Gao via ltp
2026-05-06 13:16 ` Andrea Cervesato via ltp [this message]
2026-04-15 10:37 ` [LTP] [PATCH v7 " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69fb3f13.5d0a0220.d655e.1133@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox