Re: [LTP] [PATCH v2] cfs-scheduler: Fixed "make check" errors and warnings.

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Samir,

the AI agent didn't reply to your email at that time, but the
output is the following and I agree with that:

> Patch v1: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/
>
> Addressed review comments from patch v1 -> patch v2
> hackbench.c:
> - Drop SPDX-License-Identifier header addition.
> ...

Version changelog (v1->v2 notes, bullet lists, Patch vN links) must be
stripped before the final commit is applied. Move them to the cover
letter or drop them entirely.

[...]

> -/* This program is free software;  you can redistribute it and/or modify      */
> -/* it under the terms of the GNU General Public License as published by       */
> -/* the Free Software Foundation; either version 2 of the License, or          */
> -/* (at your option) any later version.                                        */

The GPL license prose was removed but no SPDX header was added. Add
// SPDX-License-Identifier: GPL-2.0-or-later as the first line to
replace the boilerplate; do not leave the file without a license.

[...]

The cfs_bandwidth01.c and hackbench.c changes address different scopes
(one line vs. 13 style items). Consider splitting into two commits.

Regards,
LTP AI Reviewer

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp