Re: [LTP] [PATCH] Fix memcontrol02 test failure on powerpc.

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi Pavithra,

> memcontrol02 test is failing on PowerPC with 50MB allocation. Increase to
> 100MB for both anonymous and page cache tests, and bump minimum
> device size from 300MB to 400MB accordingly.

can you please explain better what's the real issue? We need
a technical explaination of why this test is failing in PPC.

> 
> Signed-off-by: Pavithra <pavrampu@linux.ibm.com>
> ---
>  testcases/kernel/controllers/memcg/memcontrol02.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/testcases/kernel/controllers/memcg/memcontrol02.c b/testcases/kernel/controllers/memcg/memcontrol02.c
> index 0b79403c9..fcce82d68 100644
> --- a/testcases/kernel/controllers/memcg/memcontrol02.c
> +++ b/testcases/kernel/controllers/memcg/memcontrol02.c
> @@ -32,9 +32,9 @@ static struct tst_cg_group *cg_child;
>  static int fd;
>  static int file_to_all_error = 10;
>  
> -static void alloc_anon_50M_check(void)
> +static void alloc_anon_100M_check(void)

Also this function name is quite wrong. We are exposing internal
function implementation in the name itself. This needs to be
fixed with a name that is not exposing the quantity of MB we are
actually allocating, since it may change in the future.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp