From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it, LTP AI Reviewer <ltp-ai@noreply.github.com>
Subject: Re: [LTP] checkpatch: Pass git root
Date: Tue, 19 May 2026 08:56:03 +0000 [thread overview]
Message-ID: <6a0c25a4.a8d7227c.15d3fa.10da@mx.google.com> (raw)
In-Reply-To: <20260513162256.3968-1-linuxtestproject.agent@gmail.com>
Hi Petr,
> Hi Petr,
>
> On Wed, 13 May 2026, Petr Vorel wrote:
> > checkpatch: Pass git root
>
> > -CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f
> > +CHECK_NOFLAGS ?= CHECKPATCH_CONFIG_DIR="$(abs_top_srcdir)" $(abs_top_srcdir)/scripts/checkpatch.pl -f --root $(abs_top_srcdir)
>
> Note: there is a double space between `-f` and `--root`; consider collapsing
> to a single space for consistency.
>
Can you please fix this before merging the patch?
Otherwise LGTM
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-05-19 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 13:49 [LTP] [PATCH 1/1] checkpatch: Pass git root Petr Vorel
2026-05-13 16:22 ` [LTP] " linuxtestproject.agent
2026-05-19 8:56 ` Andrea Cervesato via ltp [this message]
2026-05-27 7:37 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0c25a4.a8d7227c.15d3fa.10da@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=ltp-ai@noreply.github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox