From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Cyril Hrubis" <chrubis@suse.cz>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v5 1/2] firmware/fw_load: rewrite firmware loading test using new LTP API
Date: Thu, 11 Jun 2026 09:43:58 +0000 [thread overview]
Message-ID: <6a2a835f.5d1dab49.20a12a.a427@mx.google.com> (raw)
In-Reply-To: <aip-qWO-Ep2WxLr0@yuki.lan>
Hi Cyril,
> Hi!
> > ---
> > runtest/kernel_misc | 2 +-
> > .../{fw_load_kernel => fw_load}/.gitignore | 1 +
> > .../firmware/{fw_load_kernel => fw_load}/Makefile | 8 +-
> > testcases/kernel/firmware/fw_load/fw_load.h | 18 ++
> > testcases/kernel/firmware/fw_load/fw_load01.c | 165 ++++++++++++++++
> > .../{fw_load_kernel => fw_load}/ltp_fw_load.c | 0
> > testcases/kernel/firmware/fw_load_user/.gitignore | 1 -
> > testcases/kernel/firmware/fw_load_user/Makefile | 20 --
> > testcases/kernel/firmware/fw_load_user/README | 11 --
> > testcases/kernel/firmware/fw_load_user/fw_load.c | 213 ---------------------
>
> This is impossible to review. If you move/rename files it's usually done
> in a separate patch that does not change the content.
I usually review with double column editor left=old, right=new :-)
But I agree with you that diff is messed up. Should I send a new
version?
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-11 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 7:57 [LTP] [PATCH v5 0/2] Rewrite fw_load test using new API Andrea Cervesato
2026-06-11 7:57 ` [LTP] [PATCH v5 1/2] firmware/fw_load: rewrite firmware loading test using new LTP API Andrea Cervesato
2026-06-11 9:23 ` Cyril Hrubis
2026-06-11 9:43 ` Andrea Cervesato via ltp [this message]
2026-06-11 10:08 ` Cyril Hrubis
2026-06-11 7:57 ` [LTP] [PATCH v5 2/2] firmware/fw_load: add fw_load02 for custom firmware path Andrea Cervesato
2026-06-11 9:26 ` Cyril Hrubis
2026-06-11 9:36 ` Andrea Cervesato via ltp
2026-06-11 10:07 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2a835f.5d1dab49.20a12a.a427@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=chrubis@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox