From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Avinesh Kumar via ltp" <ltp@lists.linux.it>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] tst_security.sh: Use enforce toggle to trigger SELinux measurement
Date: Tue, 16 Jun 2026 08:34:00 +0000 [thread overview]
Message-ID: <6a310a79.379593d1.36e868.af2f@mx.google.com> (raw)
In-Reply-To: <20260615111358.73462-1-avinesh.kumar@suse.com>
Hi Avinesh,
The patch looks good. For some reason we didn't receive the
agent review which spotted a bug in the test as well.
I think this is wroth to fix on a separate patch as well.
WDYT?
---
Pre-existing issue (not introduced by this patch):
tst_disable_selinux() at line 122 uses "cat 0 > $f", which tries
to read a file named "0" rather than writing the value 0 to the
enforce file. This should be "echo 0 > $f".
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-06-16 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 16:38 [LTP] [PATCH] tst_security.sh: Use enforce toggle to trigger SELinux measurement Avinesh Kumar via ltp
2026-06-12 19:07 ` [LTP] " linuxtestproject.agent
2026-06-15 11:13 ` [LTP] [PATCH v2] " Avinesh Kumar via ltp
2026-06-15 13:17 ` [LTP] " linuxtestproject.agent
2026-06-16 8:34 ` Andrea Cervesato via ltp [this message]
2026-06-16 9:25 ` [LTP] [PATCH v2] " Avinesh Kumar via ltp
2026-06-16 10:58 ` Andrea Cervesato via ltp
2026-06-30 7:57 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a310a79.379593d1.36e868.af2f@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox