From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Michael Menasherov via ltp" <ltp@lists.linux.it>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v15 2/2] futex_cmp_requeue03: Add EFAULT error coverage test
Date: Wed, 17 Jun 2026 12:34:27 +0000 [thread overview]
Message-ID: <6a329453.f77846b0.1cf411.6a0d@mx.google.com> (raw)
In-Reply-To: <20260616183025.26554-3-mmenashe@redhat.com>
Hi Michael,
the patch LGTM, but agent is right: we are missing a unaccessible
memory test for addr2.
{
.desc = "uaddr2 PROT_NONE",
.uaddr = &futex_ptr,
.uaddr2 = &prot_none_addr,
.exp_errno = EFAULT,
},
The test description is mentioning this check but there's no trace
of it inside test code.
Please send a follow-up patch, then we can merge it if no issues
will pop up.
Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-06-17 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 18:30 [LTP] [PATCH v15 0/2] futex: Add EFAULT coverage for wake and cmp_requeue Michael Menasherov via ltp
2026-06-16 18:30 ` [LTP] [PATCH v15 1/2] futex_wake05: Add EFAULT error coverage test Michael Menasherov via ltp
2026-06-16 19:47 ` [LTP] " linuxtestproject.agent
2026-06-17 12:07 ` [LTP] [PATCH v15 1/2] " Andrea Cervesato via ltp
2026-06-17 13:07 ` Cyril Hrubis
2026-06-16 18:30 ` [LTP] [PATCH v15 2/2] futex_cmp_requeue03: " Michael Menasherov via ltp
2026-06-17 12:34 ` Andrea Cervesato via ltp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a329453.f77846b0.1cf411.6a0d@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox