Re: [LTP] [PATCH 05/13] vma05.sh, keyctl01.sh: Add groups

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

> Hi!
> > as I already mentioned, I think we should do this in all tests,
> > instead of having it only for shell tests. I know manual groups
> > are error-prone, but they give us good control over what we are
> > setting up.
> > 
> > I'm not sure if adding groups based on folders as we decided to
> > do it for C API is a good idea. A tst_test->groups array feels
> > better suited, if shell tests can't automatically support the
> > same approach.
> 
> I fear that we will have a lot of typos and wrong data in there. We had
> quite a few wrong CVE tags already, because we weren't checking them for
> validity.
> 
> I'm okay with this as long as we have a checks in 'make check' that make
> sure that the manually assigned groups are correct. For that we would
> need the same heuristic we have for automatic groups to check that we
> didn't miss anything and a list of valid groups to check againts to
> guard againts typos.

Don't forget we also have the agent that works quite good on these
small tasks. We can add a rule and make sure they are always valid
groups.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp