Re: [LTP] [PATCH] checkpatch: relax parenthesis style checks

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

> I'd say it depends how your displays tabs (if tabs are in the sources, we have
> .editorconfig, but not all not all developers have their editor set to use it).
> In certain setup it does not look OK + the problem of inconsistency, but I'm ok
> to ignore it.

At the moment i use the standard kernel guidelines for TAB (8 spaces)

> 
> > > * OPEN_ENDED_LINE asks for not ending line with '(' or '['.
> > > i.e. instead of this:
> > > 	ruleset_fd = TST_EXP_FD_SILENT(
> > > 								   tst_syscall(__NR_landlock_create_ruleset, ruleset_attr,
> > > 						   sizeof(struct tst_landlock_ruleset_attr_abi1), 0));
> > > have this:
> > > 	ruleset_fd = TST_EXP_FD_SILENT(tst_syscall(__NR_landlock_create_ruleset, ruleset_attr,
> > > 						   sizeof(struct tst_landlock_ruleset_attr_abi1), 0));
> 
> > you choose the right example, landlock testing suite has been updated to
> > match this rule and now it has stuff like:
> 
> > 	apply_landlock_fs_layer(ruleset_attr, sizeof(struct tst_landlock_ruleset_attr_abi1),
> > 				path_beneath_attr, MNTPOINT, LANDLOCK_ACCESS_FS_IOCTL_DEV);

For some reason my email client is not showing the correct spaces in the
example:

my_ret_val = apply_landlock_fs_layer(ruleset_attr, sizeof(struct tst_landlock_ruleset_attr_abi1),
                                     path_beneath_attr, MNTPOINT, LANDLOCK_ACCESS_FS_IOCTL_DEV);

or:


my_ret_val = apply_landlock_fs_layer(ruleset_attr,
                                     sizeof(struct tst_landlock_ruleset_attr_abi1),
                                     path_beneath_attr,
                                     MNTPOINT, LANDLOCK_ACCESS_FS_IOCTL_DEV);

to escape the 80-100 lines rule.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp