From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Samir Mulani" <samir@linux.ibm.com>
Cc: Samir Mulani <samir@linux.ibm.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.
Date: Tue, 28 Jul 2026 13:32:33 +0000 [thread overview]
Message-ID: <6a68af72.b682100b.f12c1.0bc9@mx.google.com> (raw)
In-Reply-To: <20260722114047.54671-1-samir@linux.ibm.com>
Hi Samir,
> Link: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/ #v1
> Link: https://lore.kernel.org/ltp/20260412122842.1074017-1-samir@linux.ibm.com/ #v2
> Link: https://lore.kernel.org/ltp/20260602095656.404290-1-samir@linux.ibm.com/ #v3
This should never be part of the commit message, but stay in the `---`
section below.
The rest LGTM, but you have missed a couple of warnings:
CHECK testcases/kernel/sched/cfs-scheduler/hackbench.c
hackbench.c:82: WARNING: Prefer using '"%s...", __func__' to using 'fdpair', this function's name, in a string
hackbench.c:93: WARNING: Prefer using '"%s...", __func__' to using 'ready', this function's name, in a string
hackbench.c:310: WARNING: Prefer using '"%s...", __func__' to using 'main', this function's name, in a string
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-07-28 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 11:40 [LTP] [PATCH v4] sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c Samir Mulani
2026-07-22 13:54 ` [LTP] " linuxtestproject.agent
2026-07-28 13:32 ` Andrea Cervesato via ltp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a68af72.b682100b.f12c1.0bc9@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=samir@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox