From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it, AnonymeMeow <anonymemeow@gmail.com>
Subject: Re: [LTP] fanotify20: Skip FAN_REPORT_PIDFD | FAN_REPORT_TID test on v7.2+
Date: Tue, 28 Jul 2026 13:53:50 +0000 [thread overview]
Message-ID: <6a68b46f.f3563870.c8a40.1a2b@mx.google.com> (raw)
In-Reply-To: <20260617073757.3983-1-linuxtestproject.agent@gmail.com>
Hi AnonymeMeow,
> --- [PATCH 1/5] ---
>
> > + if (tst_kvercmp(7, 2, 0) >= 0)
> > + tst_brk(TCONF, "FAN_REPORT_PIDFD | FAN_REPORT_TID is supported "
> > + "since v7.2, skipping test");
>
> tst_brk(TCONF) in setup aborts ALL test cases. The second test case
> (FAN_REPORT_PIDFD | FAN_REPORT_FID | FAN_REPORT_DFID_NAME expected to
> succeed) is still valid on v7.2+ but will never run.
>
> Should this be a per-test-case skip instead, so that only the EINVAL
> case is skipped on v7.2+?
This observation is correct. If v7.2+ enabled only pidfd + tid combination
for fanotify, we should not skip pidfd + fid. The 1/5 patch needs to be
updated to use a per tcase TCONF.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-07-28 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 21:04 [LTP] [PATCH v2 0/5] fanotify: update pidfd tests for FAN_REPORT_TID AnonymeMeow
2026-06-16 21:04 ` [LTP] [PATCH v2 1/5] fanotify20: Skip FAN_REPORT_PIDFD | FAN_REPORT_TID test on v7.2+ AnonymeMeow
2026-06-17 7:37 ` [LTP] " linuxtestproject.agent
2026-07-28 13:53 ` Andrea Cervesato via ltp [this message]
2026-07-29 5:51 ` Andrea Cervesato via ltp
2026-06-17 15:33 ` [LTP] [PATCH v2 1/5] " Jan Kara
2026-06-16 21:04 ` [LTP] [PATCH v2 2/5] fanotify21: Stop relying on exited child for pidfd error AnonymeMeow
2026-06-16 21:04 ` [LTP] [PATCH v2 3/5] fanotify21: Simplify read_pidfd_fdinfo() AnonymeMeow
2026-06-16 21:04 ` [LTP] [PATCH v2 4/5] fanotify21: Add test variants for FAN_REPORT_TID AnonymeMeow
2026-06-16 21:04 ` [LTP] [PATCH v2 5/5] fanotify21: Add FAN_REPORT_TID pidfd coverage AnonymeMeow
2026-06-17 15:04 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a68b46f.f3563870.c8a40.1a2b@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=anonymemeow@gmail.com \
--cc=linuxtestproject.agent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox