From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Petr Vorel" <pvorel@suse.cz>
Cc: linux-integrity@vger.kernel.org, ltp@lists.linux.it,
linuxtestproject.agent@gmail.com
Subject: Re: [LTP] ima_setup.sh: Fix check_policy_writable() for kernel < 4.5
Date: Wed, 29 Jul 2026 06:54:17 +0000 [thread overview]
Message-ID: <6a69a39b.a148a86f.57214.897a@mx.google.com> (raw)
In-Reply-To: <20260728133556.GA1128467@pevik>
Hi Petr,
> > - "log" is created in the test working directory by
> > check_policy_writable() and load_ima_policy() and is never removed.
> False positive - file is removed during cleanup of the temporary directory
> because all tests use TST_NEEDS_TMPDIR=1.
>
> > - $IMA_POLICY is expanded unquoted throughout ima_setup.sh.
> False positive - /sys/kernel/security/ima/policy does not need to be quoted.
this is kinda normal (unfortunately). As you can see the amount of rules
for shell tests is really basic and it doesn't cover many cases:
https://github.com/linux-test-project/ltp-agent/blob/master/rules/shell-tests.md
Feel free to create a PR to avoid these false positive.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-07-29 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:42 [LTP] [PATCH 1/1] ima_setup.sh: Fix check_policy_writable() for kernel < 4.5 Petr Vorel
2026-07-28 12:58 ` [LTP] " linuxtestproject.agent
2026-07-28 13:35 ` Petr Vorel
2026-07-29 6:54 ` Andrea Cervesato via ltp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a69a39b.a148a86f.57214.897a@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linuxtestproject.agent@gmail.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox