From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation
Date: Wed, 19 Aug 2026 07:11:09 +0000 [thread overview]
Message-ID: <6a85570e.c9eda3e9.2eb60d.c6b0@mx.google.com> (raw)
In-Reply-To: <20260819034819.8622-1-linuxtestproject.agent@gmail.com>
Hi Wei,
> > #define TST_ASSERT_ULONG(path, val, ...) \
> > tst_assert_ulong(__FILE__, __LINE__, path, val, (0, ##__VA_ARGS__))
>
> Could this avoid the comma expression? When a flag is supplied, its left-hand
> operand triggers -Wunused-value, so all three new compat-mode assertions emit
> compiler warnings and builds using -Werror fail. Making the flags argument
> explicit and passing 0 at no-flag call sites, or dispatching separate two- and
> three-argument macro forms, would avoid the warning.
This is correct, we can use TST_2_ which is our default way to avoid these
issues.
#define TST_ASSERT_ULONG(path, val, ...) \
tst_assert_ulong(__FILE__, __LINE__, path, val, \
TST_2_(dummy, ##__VA_ARGS__, 0))
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-19 7:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 9:26 [LTP] [PATCH v1] shmctl03: Fix 32-bit compat mode failure by forcing limits Wei Gao via ltp
2026-04-10 13:14 ` Andrea Cervesato via ltp
2026-04-10 14:12 ` Wei Gao via ltp
2026-04-10 14:32 ` Andrea Cervesato via ltp
2026-04-13 6:19 ` [LTP] [PATCH v2] shmctl03: Fix 32-bit compat mode failure by adjusting comparisons for compat mode truncation Wei Gao via ltp
2026-04-29 8:04 ` [LTP] " linuxtestproject.agent
2026-04-29 11:18 ` [LTP] [PATCH v3] " Wei Gao via ltp
2026-04-29 12:33 ` [LTP] " linuxtestproject.agent
2026-04-30 3:47 ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-04-30 6:35 ` [LTP] " linuxtestproject.agent
2026-05-06 17:28 ` Andrea Cervesato via ltp
2026-05-07 9:51 ` Wei Gao via ltp
2026-05-07 10:01 ` Andrea Cervesato via ltp
2026-08-19 3:17 ` [LTP] [PATCH v5] " Wei Gao via ltp
2026-08-19 3:48 ` [LTP] " linuxtestproject.agent
2026-08-19 7:11 ` Andrea Cervesato via ltp [this message]
2026-08-19 8:38 ` [LTP] [PATCH v6] " Wei Gao via ltp
2026-08-19 9:39 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a85570e.c9eda3e9.2eb60d.c6b0@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox