From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: Samir Mulani <samir@linux.ibm.com>, ltp@lists.linux.it
Subject: Re: [LTP] mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget
Date: Tue, 25 Aug 2026 11:16:07 +0000 [thread overview]
Message-ID: <6a8d7978.544c37d8.59786.e134@mx.google.com> (raw)
In-Reply-To: <20260818192956.8788-1-linuxtestproject.agent@gmail.com>
Hi Samir,
> Could the checkpatch-only changes be moved to a separate patch? The
> SAFE_SHMGET() conversion is a behavioral API cleanup, while hugeshmget03
> contains only independent message-formatting changes. LTP requires each
> patch to contain one logical change.
This agent review is actually accurate. Please split the patch in two, so
SAFE_SHMGET() and checkpatch cleanup are separated.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-08-25 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 13:18 [LTP] [PATCH v3] mem/hugetlb: use SAFE_SHMGET() and fix checkpatch warnings in hugeshmget Samir Mulani
2026-08-18 19:29 ` [LTP] " linuxtestproject.agent
2026-08-25 11:16 ` Andrea Cervesato via ltp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a8d7978.544c37d8.59786.e134@mx.google.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=linuxtestproject.agent@gmail.com \
--cc=samir@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox