Linux Test Project
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: linuxtestproject.agent@gmail.com
Cc: ltp@lists.linux.it
Subject: Re: [LTP] setsockopt08: Handle EPERM from disabled compat xtables in userns
Date: Fri, 28 Aug 2026 11:33:26 +0000	[thread overview]
Message-ID: <6a917207.e53d905a.2edf82.82b8@mx.google.com> (raw)
In-Reply-To: <20260828113033.8995-1-linuxtestproject.agent@gmail.com>

Hi Avinesh,

> > +	if (TST_RET == -1 && TST_ERR == EPERM  && tst_is_compat_mode()) {
> 
> Minor: Could the extra space before the second && be removed to follow
> the surrounding kernel style?

this can be fixed before merge.

> 
> > +		tst_res(TINFO, "32bit compat xtables interface is disabled in user namespaces since commit ec1806a730a1");
> 
> Minor: Could this 108-column line be wrapped to stay within the kernel
> style's 100-column limit?

this is not needed. I will add a rule for this.

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-28 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  9:57 [LTP] [PATCH] setsockopt08: Handle EPERM from disabled compat xtables in userns Avinesh Kumar via ltp
2026-08-28 11:16 ` Andrea Cervesato via ltp
2026-08-28 11:16   ` Andrea Cervesato via ltp
2026-08-28 11:25 ` Andrea Cervesato via ltp
2026-08-28 11:30 ` [LTP] " linuxtestproject.agent
2026-08-28 11:33   ` Andrea Cervesato via ltp [this message]
2026-09-03 13:09 ` [LTP] [PATCH] " Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a917207.e53d905a.2edf82.82b8@mx.google.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=linuxtestproject.agent@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox