Linux Test Project
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Li Wang" <li.wang@linux.dev>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v6 2/2] coredump02: Verify ELF structure and notes
Date: Fri, 04 Sep 2026 10:49:57 +0000	[thread overview]
Message-ID: <6a9aa256.ed0817e7.6bb22.ec68@mx.google.com> (raw)
In-Reply-To: <apqM3bxh26RrnN3g@linux.dev>

Hi Li,

> Splitting the core file parsing into a separate test is fine.
> For the duplicated code, there are two approaches - I'm okay
> with either.
> 
> 1. create a seperate coredump_common.h

It makes sense, I would stick with this one, because I'm trying to keep
tests as atomic as possible. They are way easier to maintain and to debug

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2026-09-04 10:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04  7:15 [LTP] [PATCH v6 0/2] coredump testing suite Andrea Cervesato
2026-09-04  7:15 ` [LTP] [PATCH v6 1/2] coredump01: New core_pattern specifiers test Andrea Cervesato
2026-09-04  7:52   ` [LTP] " linuxtestproject.agent
2026-09-04  7:15 ` [LTP] [PATCH v6 2/2] coredump02: Verify ELF structure and notes Andrea Cervesato
2026-09-04  9:18   ` Li Wang
2026-09-04 10:49     ` Andrea Cervesato via ltp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a9aa256.ed0817e7.6bb22.ec68@mx.google.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=li.wang@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox