[LTP] [PATCH v2] pthread_cancel_3-1: rewrite

Li Wang
2018-06-05T02:02:22Z

Jan Stancek <jstancek@redhat.com> wrote:

> This test sets priorities, measures time, tries to synchronize
> threads with integers and sleeps for seconds. And there appears
> to be race somewhere that makes it rarely fail.
>
> The premise tested is that action triggered by pthread_cancel
> runs asynchronously. This rewrite takes simpler approach:
>
> Thread sleeps until it can observe variable set by parent
> _after_ pthread_cancel() or after it hits specified timeout.
> If timeout is hit, then presumably cleanup_func() didn't
> run in parallel with main thread and test fails.
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ​[...]​
>
> +static void cleanup_func(void *unused)
>
​
To get rid of compile warning:​
​ static void cleanup_func(void *unused __attribute__((unused)))
​

> +{
> + do {
> + usleep(SLEEP_MS*1000);
> + thread_sleep_time += SLEEP_MS;
> + } while (after_cancel == 0 && thread_sleep_time < TIMEOUT_MS);
> +}
> +
> +static void *thread_func(void *unused)
>

​Here as well.​

​Others looks good to me.​

--
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180605/5ea97e1a/attachment.html>