Linux Test Project
 help / color / mirror / Atom feed
From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Li Wang <liwang@redhat.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] statx04: Remove kernel comments in docparse
Date: Fri, 19 Aug 2022 14:10:33 +0000	[thread overview]
Message-ID: <75b595dd-fdcb-73db-0e71-d36d665bbad8@fujitsu.com> (raw)
In-Reply-To: <CAEemH2d97boX8x3+XKS23djO93S3+og+5r9RDFp3gzo97mMp+A@mail.gmail.com>


Hi Li

>     So for me, If remove kernel commit in description, then I only see
>     useless commit id number, unless I go to search them in kernel org.
> 
> 
> Not exactly, another thing to make people's attention is test fail with 
> hint,
> then we can simply click the link.

I remember Amir also added a similar feature[1] to xfstests when he 
become xfs 5.10 stable kernel maintainer.

So maybe we can add a third colume in tst_test struct's tag field  to 
cover kernel commit title? Then this kernel comment can be removed.

Also, I don't have strong obejection to this patch because it seems 
duplicate, but I just want to keep kernel commit title by using simple way.

[1]https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=4fb72cffd9e3251149d9fa25daa96b2e26b62eab

Best Regards
Yang Xu
> 

>      58	HINT: You _MAY_ be missing kernel fixes:
>      59	
>      60	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93bc420ed41d  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93bc420ed41d>
>      61	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99652ea56a41  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99652ea56a41>
>      62	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04a87e347282  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04a87e347282>  
>      63https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f955f26f3d4  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f955f26f3d4>
> 
> 
> -- 
> Regards,
> Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-08-19 14:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  9:07 [LTP] [PATCH 1/1] statx04: Remove kernel comments in docparse Petr Vorel
2022-08-19 10:02 ` xuyang2018.jy
2022-08-19 10:10   ` xuyang2018.jy
2022-08-19 11:22     ` Petr Vorel
2022-08-19 12:42       ` Li Wang
2022-08-19 12:55     ` Li Wang
2022-08-19 14:10       ` xuyang2018.jy [this message]
2022-08-19 14:32         ` Petr Vorel
2022-08-20  2:03           ` Li Wang
2022-08-22 10:17             ` Petr Vorel
2022-08-19 12:36 ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75b595dd-fdcb-73db-0e71-d36d665bbad8@fujitsu.com \
    --to=xuyang2018.jy@fujitsu.com \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox