From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/4] Add dependency checking
Date: Mon, 16 Jul 2018 11:52:44 -0400 (EDT) [thread overview]
Message-ID: <769723769.33318962.1531756364899.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180711122925.24278-1-punit.agrawal@arm.com>
----- Original Message -----
> Hi,
>
> While investigating failures from nightly runs, I came across some
> tests that don't explicitly check for dependencies.
>
> Add appropriate check for dependencies so the tests are reported as an
> issue with the configuration rather than a test failure. These set of
> patches transitions ~50-60 tests from reporting failures to a
> configuration issue.
>
> Thanks,
> Punit
>
Hi,
Pushed with the exception of patch 2.
Switching quota_remount_test01.sh away from apicmds will
likely need more changes, e.g. it should use at least
tst_exit().
If we take the effort to port this test to shell library,
it should be "tst_test.h" one.
If you're up to rewriting test for tst_test.h, that would
be preffered. Otherwise, I rather use some shell check
and avoid including "test.h" for the sole purpose of having
tst_check_cmds.
Regards,
Jan
next prev parent reply other threads:[~2018-07-16 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 12:29 [LTP] [PATCH 0/4] Add dependency checking Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 1/4] controllers/cgroup_fj_common.sh: Check for dependencies during setup Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 2/4] quota_remount_test01: Add explicit check for dependencies Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 3/4] memcg_lib.sh: Check for killall Punit Agrawal
2018-07-11 12:29 ` [LTP] [PATCH 4/4] controllers/pids.sh: " Punit Agrawal
2018-07-16 15:52 ` Jan Stancek [this message]
2018-07-16 16:20 ` [LTP] [PATCH 0/4] Add dependency checking Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769723769.33318962.1531756364899.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox