From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK
Date: Wed, 26 Feb 2020 04:22:46 -0500 (EST) [thread overview]
Message-ID: <793226027.9074640.1582708966090.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200226084249.29561-1-pvorel@suse.cz>
----- Original Message -----
> To fix unreported results error:
> tst_test.c:1036: BROK: Test haven't reported results!
>
> which also prevents to display kernel commit fix and CVE.
>
> Fixes: 8ac26843e ("syscalls/request_key04: new test for request_key()
> permission check bug")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>
> obvious fix which I'd normally merge without sending to ML.
> But there are 19 tests which use tst_res(TBROK, and at least some of
> them are affected by this (i.e. don't unconditionally report any result
> before tst_res(TBROK), so we might want to fix it different way.
>
> Kind regards,
> Petr
>
> testcases/kernel/syscalls/request_key/request_key04.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/request_key/request_key04.c
> b/testcases/kernel/syscalls/request_key/request_key04.c
> index da036bf3a..c125f4261 100644
> --- a/testcases/kernel/syscalls/request_key/request_key04.c
> +++ b/testcases/kernel/syscalls/request_key/request_key04.c
> @@ -65,7 +65,7 @@ static void do_test(void)
> if (TST_ERR == EACCES) {
> tst_res(TPASS, "request_key() failed with EACCES as expected");
> } else {
> - tst_res(TBROK | TTERRNO,
> + tst_res(TFAIL | TTERRNO,
> "request_key() failed with unexpected error code");
> }
> }
> --
> 2.25.1
Ack
prev parent reply other threads:[~2020-02-26 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 8:42 [LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK Petr Vorel
2020-02-26 9:00 ` Li Wang
2020-02-26 9:18 ` Petr Vorel
2020-02-26 9:50 ` Li Wang
2020-02-26 11:37 ` Petr Vorel
2020-02-26 12:04 ` Xiao Yang
2020-02-26 12:48 ` Cyril Hrubis
2020-02-26 13:23 ` Jan Stancek
2020-02-26 14:02 ` Petr Vorel
2020-02-26 9:22 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793226027.9074640.1582708966090.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox