From: Jan Stancek <jstancek@redhat.com>
To: Monson Shao <jshao@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] setns: add ns_name in TINFO
Date: Thu, 17 Oct 2013 06:03:40 -0400 (EDT) [thread overview]
Message-ID: <795452447.8347120.1382004220978.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1382002005-15348-1-git-send-email-jshao@redhat.com>
----- Original Message -----
> From: "Monson Shao" <jshao@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Thursday, 17 October, 2013 11:26:45 AM
> Subject: [LTP] [PATCH] setns: add ns_name in TINFO
>
> Make it clear which namespace is enabled and being tested.
Fine by me, it's easier to read than those flags.
Reviewed-by: Jan Stancek <jstancek@redhat.com>
Regards,
Jan
>
> before:
> setns01 0 TINFO : ns_fds[0]=5, ns_types[0]=0x8000000
> setns01 0 TINFO : ns_fds[1]=6, ns_types[1]=0x20000
> setns01 0 TINFO : ns_fds[2]=7, ns_types[2]=0x40000000
> setns01 0 TINFO : ns_fds[3]=8, ns_types[3]=0x20000000
> setns01 0 TINFO : ns_fds[4]=9, ns_types[4]=0x4000000
>
> after:
> setns01 0 TINFO : ns_name=ipc, ns_fds[0]=5, ns_types[0]=0x8000000
> setns01 0 TINFO : ns_name=mnt, ns_fds[1]=6, ns_types[1]=0x20000
> setns01 0 TINFO : ns_name=net, ns_fds[2]=7, ns_types[2]=0x40000000
> setns01 0 TINFO : ns_name=pid, ns_fds[3]=8, ns_types[3]=0x20000000
> setns01 0 TINFO : ns_name=uts, ns_fds[4]=9, ns_types[4]=0x4000000
>
> Signed-off-by: Monson Shao <jshao@redhat.com>
> ---
> testcases/kernel/syscalls/setns/setns.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/setns/setns.h
> b/testcases/kernel/syscalls/setns/setns.h
> index 23bdb2e..a05e673 100644
> --- a/testcases/kernel/syscalls/setns/setns.h
> +++ b/testcases/kernel/syscalls/setns/setns.h
> @@ -53,8 +53,8 @@ static void init_ns_type(int clone_type, const char
> *proc_name)
> if (fd != -1) {
> ns_types[ns_total] = clone_type;
> ns_fds[ns_total] = fd;
> - tst_resm(TINFO, "ns_fds[%d]=%d, ns_types[%d]=0x%x", ns_total,
> - fd, ns_total, clone_type);
> + tst_resm(TINFO, "ns_name=%s, ns_fds[%d]=%d, ns_types[%d]=0x%x",
> + proc_name, ns_total, fd, ns_total, clone_type);
> ns_total++;
> }
> }
> --
> 1.8.3.1
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-10-17 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 9:26 [LTP] [PATCH] setns: add ns_name in TINFO Monson Shao
2013-10-17 10:03 ` Jan Stancek [this message]
2013-10-17 10:20 ` Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795452447.8347120.1382004220978.JavaMail.root@redhat.com \
--to=jstancek@redhat.com \
--cc=jshao@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox