From: sujiaxun <sujiaxun@uniontech.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] [1/6] syscalls/sysfs: Convert sysfs01 to the new API
Date: Fri, 6 Aug 2021 09:22:06 +0800 [thread overview]
Message-ID: <7da55dc8-edd4-e392-b5b5-d2adce0cfaa2@uniontech.com> (raw)
In-Reply-To: <YQvRg1O7kakkm30M@yuki>
Okay, thank you for your meticulous guidance, I will revise and submit
it again according to your suggestions.
? 2021/8/5 ??7:54, Cyril Hrubis ??:
> Hi!
>> + TEST(tst_syscall(__NR_sysfs, 1, "proc"));
>>
>> /* check return code */
>> - if (TEST_RETURN == -1) {
>> - tst_resm(TFAIL, "sysfs(2) Failed for "
>> - "option 1 and set errno to %d", TEST_ERRNO);
>> + if (TST_RET == -1) {
>> + tst_res(TFAIL, "sysfs(2) Failed for "
>> + "option 1 and set errno to %d", TST_ERR);
>> } else {
>> - tst_resm(TPASS, "sysfs(2) Passed for " "option 1");
>> + tst_res(TPASS, "sysfs(2) Passed for " "option 1");
>> }
>
> This could be just:
>
> TST_EXP_POSSITIVE(tst_syscall(__NR_sysfs, 1, "proc"),
> "sysfs(1, "proc")");
>
--
Kind regards,
sujiaxun
prev parent reply other threads:[~2021-08-06 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 6:07 [LTP] [PATCH] [1/6] syscalls/sysfs: Convert sysfs01 to the new API sujiaxun
2021-08-05 11:54 ` Cyril Hrubis
2021-08-06 1:22 ` sujiaxun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7da55dc8-edd4-e392-b5b5-d2adce0cfaa2@uniontech.com \
--to=sujiaxun@uniontech.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox